Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that PYTEST_ADDOPTS are valid by themselves #4523

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Dec 9, 2018

Ref #4265.

@pytest-dev pytest-dev deleted a comment from codecov bot Dec 9, 2018
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #4523 into master will decrease coverage by 53.4%.
The diff coverage is 26.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4523       +/-   ##
===========================================
- Coverage   95.91%   42.51%   -53.41%     
===========================================
  Files         111       92       -19     
  Lines       25093    20868     -4225     
  Branches     2448     2338      -110     
===========================================
- Hits        24068     8871    -15197     
- Misses        724    11403    +10679     
- Partials      301      594      +293
Flag Coverage Δ
#docs 29.17% <26.31%> (-0.84%) ⬇️
#doctesting 29.17% <26.31%> (-0.84%) ⬇️
#linting 29.17% <26.31%> (-0.84%) ⬇️
#linux 42.51% <26.31%> (-53.24%) ⬇️
#nobyte ?
#numpy 40.98% <26.31%> (-52.49%) ⬇️
#pexpect 40.98% <26.31%> (-0.9%) ⬇️
#py27 40.98% <26.31%> (-53.08%) ⬇️
#py34 ?
#py35 ?
#py36 ?
#py37 ?
#trial 40.98% <26.31%> (-52.49%) ⬇️
#windows ?
#xdist ?
Impacted Files Coverage Δ
testing/test_config.py 0% <0%> (-99.43%) ⬇️
src/_pytest/config/__init__.py 67.71% <71.42%> (-27.31%) ⬇️
testing/test_pastebin.py 0% <0%> (-100%) ⬇️
testing/test_resultlog.py 0% <0%> (-100%) ⬇️
testing/test_entry_points.py 0% <0%> (-100%) ⬇️
testing/test_doctest.py 0% <0%> (-100%) ⬇️
testing/test_runner_xunit.py 0% <0%> (-100%) ⬇️
testing/test_pathlib.py 0% <0%> (-100%) ⬇️
testing/test_nodes.py 0% <0%> (-100%) ⬇️
testing/deprecated_test.py 0% <0%> (-100%) ⬇️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818aa4d...711c8c2. Read the comment docs.

@nicoddemus
Copy link
Member

From #4265:

I've just noticed that with PYTEST_ADDOPTS=--cov pytest foo "foo" becomes the arg for it, which really confused me.

PYTEST_ADDOPTS will be validated separately (which is correct), but foo will still be processed by --cov, no?

@blueyed
Copy link
Contributor Author

blueyed commented Dec 9, 2018

but foo will still be processed by --cov, no?

Yeah.. :/
I've looked at bit at fixing this, and it might be possible by keeping the parsed namespace, instead of parsing all args altogether in the end, but not trivial.
I will change Fixes to Ref in the original comment.

@blueyed blueyed merged commit abb0dfc into pytest-dev:master Dec 10, 2018
@blueyed blueyed deleted the addopts-separate branch December 10, 2018 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants